build(eslint-config-fluid): update dependencies#27247
build(eslint-config-fluid): update dependencies#27247tylerbutler wants to merge 2 commits intomicrosoft:mainfrom
Conversation
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (642 lines, 9 files), I've queued these reviewers:
How this works
|
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the eslint-config-fluid package’s linting toolchain dependencies and regenerates the printed ESLint configs to align with those updates.
Changes:
- Bump versions for ESLint core packages and several ESLint plugins (e.g.,
import-x,depend,react-hooks,no-only-tests,unused-imports). - Refresh printed config outputs to reflect updated plugin versions and rule sets.
- Adjust pnpm workspace trust policy exclusions.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| common/build/eslint-config-fluid/printed-configs/test.json | Updates printed plugin versions and modifies the no-only-tests plugin entry. |
| common/build/eslint-config-fluid/printed-configs/strict.json | Updates printed plugin versions (import-x, depend). |
| common/build/eslint-config-fluid/printed-configs/strict-biome.json | Updates printed plugin versions (import-x, depend). |
| common/build/eslint-config-fluid/printed-configs/recommended.json | Updates printed plugin versions (import-x, depend). |
| common/build/eslint-config-fluid/printed-configs/react.json | Updates printed plugin versions and removes a react-hooks rule from the printed ruleset. |
| common/build/eslint-config-fluid/printed-configs/default.json | Updates printed plugin versions (import-x, depend). |
| common/build/eslint-config-fluid/pnpm-workspace.yaml | Adds semver to trustPolicyExclude. |
| common/build/eslint-config-fluid/package.json | Bumps dependency/devDependency versions, pnpm version, and reorders/adjusts overrides. |
Files not reviewed (1)
- common/build/eslint-config-fluid/pnpm-lock.yaml: Language not supported
| "depend:eslint-plugin-depend@1.4.0", | ||
| "no-only-tests" | ||
| "depend:eslint-plugin-depend@1.5.0", | ||
| "no-only-tests:no-only-tests" |
| # package (including later major versions) which had better provenance information. | ||
| # ALWAYS REVIEW CAREFULLY BEFORE ADDING SOMETHING TO THIS LIST. | ||
| trustPolicyExclude: [] | ||
| trustPolicyExclude: ["semver"] |
| "error", | ||
| "always" | ||
| ], | ||
| "react-hooks/component-hook-factories": [ | ||
| "error" | ||
| ], | ||
| "react-hooks/config": [ | ||
| "error" | ||
| ], |
ChumpChief
left a comment
ChumpChief
left a comment
There was a problem hiding this comment.
Just a nit but you might want a second opinion on the trust policy change.
| "chokidar": "^5", | ||
| "diff@>=5 <6": "^5.2.2", | ||
| "js-yaml": "^4.1.1", | ||
| "minimatch@>=10 <11": "^10.2.4", |
| # package (including later major versions) which had better provenance information. | ||
| # ALWAYS REVIEW CAREFULLY BEFORE ADDING SOMETHING TO THIS LIST. | ||
| trustPolicyExclude: [] | ||
| trustPolicyExclude: ["semver"] |
There was a problem hiding this comment.
I know @TommyBrosman has been looking at the trust policy stuff lately (e.g. #27254) - might want to get an opinion from someone who knows about that stuff more than I do.
There was a problem hiding this comment.
Good point - I won't commit this way.
Updates eslint dependencies.